internal/ and libs/ were both shared-code roots with no rule for which
one a package belonged in, so the split carried no information. Adopt a
rule the language answers by itself:
shared Go -> internal/
shared TypeScript -> libs/ (npm workspace packages)
libs/{ports,repo,server} move to internal/, leaving libs/ holding only
the two TypeScript packages (@jobs-scraper/rabbitmq-ts and
@jobs-scraper/browser-automation), which matches npm workspace
convention. internal/ is also Go's marker for code not importable from
outside the repo, which is accurate here since none of it is published.
Import paths are rewritten mechanically (jobs-scraper/libs/ ->
jobs-scraper/internal/) across 15 lines in 10 files. The 6 moved files
are pure renames with no content change. Doing this after the module
collapse in the previous commit meant no go.mod or replace-directive
edits were needed.
gofmt is applied to services/api/pkg/http/job.go, whose import group the
rewrite left out of order. Three files were already unformatted before
this refactor (internal/openai/interface.go, internal/ports/job-queries.go,
internal/repo/job-analysis-result.go) and are deliberately left alone to
keep this diff limited to the move.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
internal/ and libs/ were split into 9 single-package Go modules, held
together by 22 replace directives across 7 go.mod files. The module
boundaries bought nothing: internal/dto, internal/browser and
internal/migrations were already plain packages in the root module and
worked fine.
Delete the 9 go.mod/go.sum pairs so those packages belong to the root
github.com/jobs-scraper module. Import paths are unchanged --
github.com/jobs-scraper/internal/domain resolves identically whether it
is its own module or a package inside the root module -- so no .go file
is touched by this commit.
Each deployable module now needs one require + one replace on the root
module instead of four to six:
go.work entries: 14 -> 5
replace directives: 22 -> 4
go.mod files: 14 -> 5
Dependency versions are deliberately held at their previous pins. A bare
go mod tidy resolved several to latest once the per-package constraints
were gone (lib/pq 1.10.9 -> 1.12.3, amqp091-go 1.10.0 -> 1.13.0,
migrate 4.19.0 -> 4.19.1, go-openai 1.41.2 -> 1.42.0, genai
1.39.0 -> 1.66.0); all five are pinned back, since a structural refactor
should not move dependency versions.
Side effect worth noting: `go build ./...` at the repo root previously
matched only 2 packages, because everything else sat behind a module
boundary. It now covers all 12 shared packages, so the build and vet
steps in .forgejo/workflows/ actually exercise the shared code.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
internal/infrastructure/http was unreferenced: the live HTTP layer is
services/api/pkg/http, wired in services/api/cmd/server/main.go.
The deleted copy was a strict subset of the live one, not a divergence:
it lacked the GetJobs and ApplyForJob handlers and their route
registrations, and its CORS middleware hardcoded
Access-Control-Allow-Origin: * where the live version reflects the
request Origin.
Removing it also drops the only internal/ -> libs/ import edge, so
dependencies between the two shared roots now point one way
(libs/{ports,repo} -> internal/{domain,dto}). go mod tidy consequently
dropped libs/ports, libs/repo, internal/utils and gorilla/mux from
internal/infrastructure, whose orphaned replace directives are removed
here too.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
